[bug]: GQL Issue for addFTPInstance and updateFTPInstance

[danardf]

FreePBX Version

FreePBX 16

Issue Description

When we add or update any FTP instances, the data are not fully updated.
After Adding an instance, Use TLS and Filesystem Type are empty.
That mean the FTP instance is not completed and can crach the code (for exemple, unable to read the file size, giving an Error exception in backup module under Restore Tab).

Maybe add useTLS on the GQL request, otherwise, set it up on False anyway.
About Filesystem type, I think there is a confusion about that!

Indeed, In the GUI, you write: Filesystem Type, but on the documentation there is: fileStoreType and on the main code, the method returns fstype as key.
That should be nice to provide the same variables or keys every where for avoid any confusions. FS = FileStore or Filesystem? It's FilseStoreType or fsType? That is the question!

Operating Environment

| filestore | 16.0.18.1
| filestore | 17.0.2.22

Relevant log output

none.

[gogglespisano]

I think I'm experiencing this problem.

After upgrading to 17, I had to "Enable" the FTP filestore, which was ok. However, the TLS option appears to have no effect and my backups are now failing because FreePBX is not issuing the FTP "AUTH TLS" command.

Other than the Enable option, my FTP backups were working in 16.

[danardf]

@gogglespisano Whatever you set with options, there were two which was missing. : The file systems and TLS.
I don't know if TLS is really useful here. But at least, set it up by default.

[gogglespisano]

I looked in kvstore_FreePBX_modules_Filestore and "usetls" was set to "yes" (that might be from my backup), but when the backup is run, the FTP storage fails because it didn't use TLS (FTPS). Maybe my problem is the FTP code itself, and not the GUI.

Or is problem that "ssl" isn't picked up from usetls=yes/no?

This was working in 16 right before I transitioned to 17.

[danardf]

This issue also is broken backup restore because Files System is null, and it generate a exception error, when the code is trying to get file sizes. The doesn't know if it's Windows or Linux to use. As my FTP server is on Linux, then if the FTP is use Windows. That's dead.

[danardf]

Anyway, these options should be present on GQL otherwise, set it up all missing option by default.

Other things, S3, Dropbox, ...etc are not available. Looks like this part of GQL code is incomplet.