Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk Module should ignore Route Prefix #268

Open
daocow opened this issue Nov 11, 2015 · 4 comments
Open

Trunk Module should ignore Route Prefix #268

daocow opened this issue Nov 11, 2015 · 4 comments

Comments

@daocow
Copy link

daocow commented Nov 11, 2015

We use CID Name Prefix on inbound routes to show the DID the call came in on.

The problem is that when the CID Name has the route prefix added, it no longer matches either the Keywords or the Discard Numeric in the Trunk module config so the Trunk CID is always selected instead of failing through to other modules.

This is somewhat related to issue #180 and could probably be treated generically by removing the prefix at the beginning of any processing and then adding it on afterwords but should be done at least for the Trunk module where the existing value is tested and used.

@daocow
Copy link
Author

daocow commented Nov 12, 2015

So here is a patch for the trunk module against the most recent code in FreePBX.

patch1.txt

@lgaetz
Copy link
Contributor

lgaetz commented Nov 12, 2015

Thanks for the contribution. All code submissions must have a corresponding licensing agreement on file. If you have not already done so, can you please follow the instructions on this page:
http://wiki.freepbx.org/display/FOP/Code+License+Agreement

@daocow
Copy link
Author

daocow commented Nov 12, 2015

I have signed the license agreement already under the freepbx username dosborn

@lgaetz
Copy link
Contributor

lgaetz commented Nov 12, 2015

Understood, as soon as @tm1000 confirms, I will investigate your patch.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants