Wrong formatting / argument type in log traces generate warnings

[guillaumeVolery]

Problem

By building the library with arm-none-eabi-gcc compiler and setting the flag -Werror, the library is producing the following warnings (errors) due to the use of wrong format specifier in the log traces... We have the goal to deliver a warning-free software for our next firmware release.

PS: Thank for your job and for this library, you are awsome 👍

The correction is very simple, use %lu instead of %u, use %ld instead of %d.

Awaited result

New release of the library implementing the correction above and no more warning generated.

List of reported errors:

• cellular_common.c:602:20 error: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'}
• cellular_common.c:655:25: error: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_common_api.c:110:25: error: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_common_api.c:126:25: error: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_common.c:919:25: error: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_3gpp_api.c:492:21: error: format '%d' expects argument of type 'int', but argument 2 has type 'int32_t' {aka 'long int'} [-Werror=format=]
• cellular_pktio.c:145:17: error: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pkthandler.c:823:29: error: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:177:17: error: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pkthandler.c:823:29: error: format '%d' expects argument of type 'int', but argument 3 has type 'int32_t' {aka 'long int'} [-Werror=format=]
• cellular_pktio.c:186:17: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
• cellular_pkthandler.c:839:25: error: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:549:17: error: format '%d' expects argument of type 'int', but argument 4 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:620:25: error: format '%d' expects argument of type 'int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:673:21: error: format '%d' expects argument of type 'int', but argument 4 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:673:21: error: format '%d' expects argument of type 'int', but argument 5 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:673:21: error: format '%d' expects argument of type 'int', but argument 6 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:888:25: error: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:888:25: error: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:1029:21: error: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
• cellular_pktio.c:1430:17: error: format '%d' expects argument of type 'int', but argument 2 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]

[guillaumeVolery]

I have a correction ready to be pushed on freshly created branch called "150". Unfortunately, I don't have to right to push to the repo... Would it be a possibility to get the rights ?

[moninom1]

Hi @guillaumeVolery ,

Thank you so much for reporting the issue. That would be great if you want to contribute.

Unfortunately, I don't have to right to push to the repo... Would it be a possibility to get the rights ?

If the changes are in your branch, you should be able to create a PR to the main branch. Can you please let me know what issue you are facing.

[guillaumeVolery]

Hi @moninom1

Thank you for your reply.

This is actually my problem:

git push --set-upstream origin Issue150
remote: Permission to FreeRTOS/FreeRTOS-Cellular-Interface.git denied to guillaumeVolery.
fatal: unable to access 'https://github.com/FreeRTOS/FreeRTOS-Cellular-Interface.git/': The requested URL returned error: 403

I cannot push my new branch on the remote.

[moninom1]

Hi @guillaumeVolery

You need to create a fork of the repo and then push the changes to your branch in your forked repo. After that you will be able to create a PR to main branch. Please check the following steps :

1: Fork the FreeRTOS-Cellular-Interface repo
2: Clone the forked FreeRTOS-Cellular-Interface repo.
3: Add changes locally and commit it on branch Issue150.
4: Push the changes to your own forked GitHub repo branch Issue150.
5: Create a pull request from forked FreeRTOS-Cellular-Interface repo branch Issue150 to FreeRTOS main.

Let me know if this works.

[guillaumeVolery]

Hi @moninom1

Thank you for your insights. I have completed the process and you will find the pull request here.

👍

[chinglee-iot]

PR #154 is merged. We will close this issue. Feel free to reopen this issue if any further problem.