Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation Between FTS Services #740

Open
naman108 opened this issue Oct 4, 2024 · 2 comments
Open

Federation Between FTS Services #740

naman108 opened this issue Oct 4, 2024 · 2 comments
Assignees
Labels
bug_Normal Normal bug, Server connects to clients but won't sync data

Comments

@naman108
Copy link
Collaborator

naman108 commented Oct 4, 2024

Notes

  • when starting the federation server service the following exception occurs exception in checking pipes dictionary changed size during iteration
  • In the TCP CoT Service, the CoTSharePipe is the variable used to communicate between services using the legacy IPC system.
  • Currently TCPCoTService does not use the CoTSharePipe therefore it's messages are not shared amongst the services using the legacy system.
  • The current component system used by the TCPCoTService receives messages in byte format ready to be sent to clients via the ZManager but the services can't handle bytes out of the box.

Solutions

Option 1

Update Federation Services to accept bytes and serialize them to protobuf
Pros:

  • Simple
  • Minimal Change Scope

Cons:

  • Hacky
  • Adds Bloat

Option 2

Update TCP CoT Service to latest digitalpy and send options to federation service before serializing.
Pros:

  • no updates to legacy code
  • necessary update

Cons:

  • requires more extensive changes
@naman108 naman108 added the bug_Normal Normal bug, Server connects to clients but won't sync data label Oct 4, 2024
@naman108 naman108 self-assigned this Oct 4, 2024
@naman108
Copy link
Collaborator Author

naman108 commented Oct 4, 2024

@brothercorvo is this description clear?

@brothercorvo
Copy link
Collaborator

To update to latest DP we would need to understand the impact on other services. So I'll suggest 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug_Normal Normal bug, Server connects to clients but won't sync data
Projects
None yet
Development

No branches or pull requests

2 participants