Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add RTL interface #1550

Closed
ghost opened this issue Jul 26, 2021 · 6 comments · Fixed by #3970
Closed

Please add RTL interface #1550

ghost opened this issue Jul 26, 2021 · 6 comments · Fixed by #3970

Comments

@ghost
Copy link

ghost commented Jul 26, 2021

Is your feature request related to a usage problem (not a bug)? Please describe.
Hebrew and Arabic (the main RTL languages) are written from right to left. Currently, the interface of FreeTube is from left to right, even for right-to-left languages. Adding it will improve the user experience of speekers of right-to-left languages.

@ghost ghost added the enhancement New feature or request label Jul 26, 2021
@ChunkyProgrammer
Copy link
Member

ChunkyProgrammer commented Jul 30, 2021

Hi, would you be able to look at the screenshots included here #1553 and let me know if there's any changes that I'd need to make that I didn't mention at the bottom.

@ghost
Copy link
Author

ghost commented Jul 30, 2021

Hi, thank you for adding RTL support.
The interface itself looks good, but there are things to improve:

  1. The arrow in the search bars should be on the left and not on the right (חיפוש ->‏).
  2. In the channel pages, the avatar should be before (on the right) the channel name.
  3. In the comments, the avatar should be before the channel name.
  4. In the video page, the Like VS Dislike meter should be flipped.
  5. The on/off sliders should be before the text.
  6. All the setting labels should be aligned to right, and the help icon thould be after them.
    settings
  7. I do not speak Arabic (the syntax of Hebrew and Arabic is very similar), but I think the "Experimental version 0.13.2" is not set as RTL (in Hebrew, "Experimental version 0.13.2" is translated as "גרסה ניסיונית 0.13.2").

If there will be more things to improve, I'll list them too.

@ChunkyProgrammer ChunkyProgrammer self-assigned this Aug 18, 2021
@ChunkyProgrammer
Copy link
Member

I updated all of the screenshots and they are now in hebrew. let me know if there's anything else that should be changed

@ghost
Copy link
Author

ghost commented Aug 21, 2021

I updated all of the screenshots and they are now in hebrew. let me know if there's anything else that should be changed

Everything looks good to me, expect the "Autoplay" label and the labels on the sidebar, which seem to be aligned to left.
playing-screen

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants