Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: match theme of context menu when pressing 'alt' #2106

Closed
1 task done
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Mar 5, 2022 · 4 comments · Fixed by #1800
Closed
1 task done
Labels

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc

Guidelines

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

menu is always black, it doesnt matter what theme is applied.

Proposed Solution

Menu should match the applied theme

Alternatives Considered

None.

Issue Labels

visual improvement

Additional Information

No response

@vallode
Copy link
Contributor

vallode commented Mar 5, 2022

#1800 will actually cause this to sync to system preference which seems to be the current standard for Electron applications... the color of the context menu cannot be affected from our side and only system-level theming.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 5, 2022

Is it the same for #2092?

@vallode
Copy link
Contributor

vallode commented Mar 5, 2022

Is it the same for #2092?

Was about to comment there too: yes, the right click menu will also match system theme. Key point though is that it will be system theme not app theme, I think it's intentional that native menus should follow system theme options.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

Okay if that is the case i'll check if ur pr does that and close these issues if thats the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants