[Bug]: SponsorBlock segment isnt skipped

[efb4f5ff-1298-471a-8973-3d47447115dc]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.
• This issue contains only one bug.

Describe the bug

1. Go to SponsorBlock settings
2. Enable SponsorBlock
3. Enable Notify when sponsor segment is skipped
4. Set Skip Option for all segments to Auto Skip
5. Set different colors for all the segments
6. Go to https://youtu.be/qLVgr29NMA0
7. Skip to 17:24
8. See that first segment is skipped but the last one isnt

FreeTube_DMyMNeQfzu.mp4

Expected Behavior

Last segment should also be skipped

Issue Labels

inconsistent behavior

FreeTube Version

a4d45b5

Operating System Version

Win10 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

• I have encountered this bug in the latest nightly build.

[xdpirate]

I'm experiencing the same issue, and additionally, I don't get any notification when segments do get skipped.

[Revival8697]

I think I found the issue.
If the video have continuous segments (1 end at x and 1 start at x). Freetube will not skip the latter one as it is counted as already in the segment.
You can test this here: https://youtu.be/Slwai2Jhy_A?si=mVC3UhiF-SQGBxg0&t=155.
The segment at https://youtu.be/Slwai2Jhy_A?si=gpx4Um_AxMMF4mnU&t=563 will not be skipped.

[RyanHx]

Yep I've noticed the same behaviour - if there's continuous segments only the first will be skipped.
Another example here: https://youtu.be/4XscfA1dT60
Even weirder; the intro was skipped, I don't have filler segments on autoskip so that played just fine, but then the sponsored segment at 3:30 wasn't skipped, I guess since all 3 are continuous.

[metoxys]

Confirming on https://www.youtube.com/watch?v=nn2-7jMkSGs with a ~1 minute long segment ~25 seconds in not being skipped or indicated at all

[Revival8697]

I think I found the issue. If the video have continuous segments (1 end at x and 1 start at x). Freetube will not skip the latter one as it is counted as already in the segment. You can test this here: https://youtu.be/Slwai2Jhy_A?si=mVC3UhiF-SQGBxg0&t=155. The segment at https://youtu.be/Slwai2Jhy_A?si=gpx4Um_AxMMF4mnU&t=563 will not be skipped.

Hey. I was wrong about this.
The later segment does not start at x, it starts 0.067 second before x...
Source: https://sb.ltn.fi/video/Slwai2Jhy_A/?page=3&sort=starttime.
The current implementation have no check for this.
Maybe the developers want to work with SponsorBlock directly on how this should be mitigated?

[mchangrh]

The sponsorblock solution is to skip the the end of the last chained segment

Here's the code from my JS client handling overlaps https://github.com/mchangrh/sb.js/blob/08b0e7026b1ac154f2783a6f1a15f9dfd731549f/src/sb.js#L77

[efb4f5ff-1298-471a-8973-3d47447115dc]

Retrieved from dev chat

Currently each sponsorblock segment is skipped individually and as the browser player only fires the timeupdate event about once a second, by the time it fires you are already inside the next segment, so that "feature" prevents the jump from happening.

The only way of keeping that "feature" that I can think of, would be to combine the jumps for consecutive segments into one. So if you have a segment at 00:10-00:15 and then another one at 00:15-00:20, we would jump straight from 00:10 to 00:20, instead of the current system of jumping from 00:10 to 00:15 and then to 00:20

this pull request is the culprit: #3116

[Revival8697]

Hey. I was wrong about this. The later segment does not start at x, it starts 0.067 second before x... Source: https://sb.ltn.fi/video/Slwai2Jhy_A/?page=3&sort=starttime. The current implementation have no check for this. Maybe the developers want to work with SponsorBlock directly on how this should be mitigated?

SponsorBlock dev respond:

[github-actions]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.