Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Middle-clicking timestamps in comments and description to open video at that timestamp in new window #4015

Closed
5 of 6 tasks
Winterhuman opened this issue Sep 9, 2023 · 4 comments
Closed
5 of 6 tasks

[Feature Request]: Middle-clicking timestamps in comments and description to open video at that timestamp in new window #4015

Winterhuman opened this issue Sep 9, 2023 · 4 comments
Labels
E: improvement existing feature E: new feature enhancement New feature or request

Comments

@Winterhuman
Copy link

Winterhuman commented Sep 9, 2023 •
edited
Loading

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Go to a video, and navigate to a comment with a timestamp link.
  2. Click the timestamp with the middle mouse button.
  3. See the Subscriptions page open in a new window.

Expected Behavior

On middle click, open a new window for the current video with the video playback set to start at the timestamp value (similar to what would happen for an "Include Timestamp" link that'd you'd get from the Share button).

Issue Labels

inconsistent behavior

FreeTube Version

v0.19.0 Beta

Operating System Version

Arch Linux, x86_64, 6.4.12-arch1-1

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build
@Winterhuman Winterhuman added the bug Something isn't working label Sep 9, 2023
@absidue
Copy link
Member

absidue commented Sep 10, 2023

Currently they aren't proper links, they are empty links with a click handler that tells the player to seek to that timestamp. Not sure if it's possible to have your requested functionality, while still having them seek the player if you activate them normally.

@absidue absidue changed the title [Bug]: Middle-clicking timestamps in comments opens the Subscriptions page [Feature Request]: Middle-clicking timestamps in comments and description to open video at that timestamp in new window Sep 10, 2023
@absidue
Copy link
Member

absidue commented Sep 10, 2023

Changed this to a feature request.

@Winterhuman
Copy link
Author

@absidue If it isn't possible to implement the feature, disabling the ability to middle-click them might be a good idea (either as a temporary or permanent change), since the current behaviour isn't very intuitive or useful

Closed
3 tasks
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Closing this as i have opened #4018. For more info read the additional context header on that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E: improvement existing feature E: new feature enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@absidue @efb4f5ff-1298-471a-8973-3d47447115dc @Winterhuman