Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Broken Thumbnails #5031

Closed
6 tasks done
HairyMilkshakes opened this issue Apr 27, 2024 · 11 comments · Fixed by #5259
Closed
6 tasks done

[Bug]: Broken Thumbnails #5031

HairyMilkshakes opened this issue Apr 27, 2024 · 11 comments · Fixed by #5259
Labels
B: visual bug Something isn't working

Comments

@HairyMilkshakes
Copy link

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Go to homepage (subscription tab).
  2. Thumbnails won't load.
  3. x04UTSqSFz

Expected Behavior

Per picture attached.

Issue Labels

visual bug

FreeTube Version

v0.20.0-nightly-4254 Beta

Operating System Version

Windows 10

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@HairyMilkshakes HairyMilkshakes added the bug Something isn't working label Apr 27, 2024
@HairyMilkshakes
Copy link
Author

Is it possible I am being rate limited so the thumbnails aren't loading?

@vid14114
Copy link

Do you use DeArrow for thumbnails? I've found that disabling the setting shows all thumbnails again.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 29, 2024

@HairyMilkshakes RSS is being forced to avoid rate limiting but RSS was down and is working now. Do you still experience this issue?

@HairyMilkshakes
Copy link
Author

Do you use DeArrow for thumbnails? I've found that disabling the setting shows all thumbnails again.

This solved the issue for me, thanks!

@HairyMilkshakes RSS is being forced to avoid rate limiting but RSS was down and is working now. Do you still experience this issue?

Doesn't seem to be an issue as soon as I disabled the thumbnail processing through DeArrow.

@mooreye
Copy link

mooreye commented May 13, 2024

How to fix this while still using the dearrow thumbnails though? Is it stricly Dearrow's fault?

FWIW, LibreTube android app is able to load both dearrow titles and thumbnails correctly. So it doesn't seem to be Dearrow's fault.

@CartoonFan
Copy link

How to fix this while still using the dearrow thumbnails though? Is it stricly Dearrow's fault?

FWIW, LibreTube android app is able to load both dearrow titles and thumbnails correctly. So it doesn't seem to be Dearrow's fault.

I'm wondering about this as well. DeArrow is useful to me, and I don't really think just turning it off is a great solution 😔

@dfgshdsfh
Copy link

@HairyMilkshakes Could you please reopen this issue so I don't have to recreate it. Turning off dearrow is NOT a fix for whatever is going wrong.

@HairyMilkshakes
Copy link
Author

@HairyMilkshakes Could you please reopen this issue so I don't have to recreate it. Turning off dearrow is NOT a fix for whatever is going wrong.

You got it.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented May 30, 2024

@dfgshdsfh @mooreye @CartoonFan Please provide reproducible steps as i cant reproduce this issue.

@CartoonFan
Copy link

CartoonFan commented May 30, 2024

@dfgshdsfh @mooreye @CartoonFan Please provide reproducible steps as i cant reproduce this issue.

@efb4f5ff-1298-471a-8973-3d47447115dc

  1. Enable "Use DeArrow for thumbnails".

2024_05_30_15_29_07

  1. Enter a valid DeArrow Thumbnail Generator API URL. I used the default (https://dearrow-thumb.ajay.app), but the field should not be empty to ensure that FreeTube actually attempts to generate the thumbnails.

2024_05_30_15_29_15

  1. Search for something, and you'll likely find at least one broken thumbnail.

2024_05_30_15_28_40

For reference, this is what my "About" tab looks like:

2024_05_30_15_42_59

Hope this helps 🙏 💜

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jun 12, 2024

From what i can see its trying to do the following:

  1. Replaces thumbnails in search one by one
  2. Finds a video that doesnt have a replacement thumbnail
  3. Tries to replace it anyway
  4. Shows broken thumbnail

We should just skip that video if there isnt a thumbnail available. That is only if this is an issue on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: visual bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants