Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Subtitle sizing are applied to current size, not original size #5615

Closed
6 tasks done
MagicalDrizzle opened this issue Aug 27, 2024 · 0 comments · Fixed by #4978
Closed
6 tasks done

[Bug]: Subtitle sizing are applied to current size, not original size #5615

MagicalDrizzle opened this issue Aug 27, 2024 · 0 comments · Fixed by #4978
Labels
B: usability B: visual bug Something isn't working

Comments

@MagicalDrizzle
Copy link

MagicalDrizzle commented Aug 27, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

Choosing certain subtitle sizes will cause the percentage to apply to the current size of subtitle, not the original size of subtitle.
For example: Subtitle size is at 100% - Choosing 50% halves the subtitle size - Choosing 75% applies the 75% sizing to the halved subtitle size (gets smaller) . Applies to all sizes - For example choosing 200% then 400% will increase the size 2 * 4 = 8 times.
Also means that if you choose a size that's not 100% - it's impossible to get it back to 100%. (Because 75% * 100% = 75%)
Only applies if you choose a size that's not the size you already chose - i.e choosing 50% twice keep it at 50% normally.

Expected Behavior

Sizes should apply relative to original size, so choosing 50% then 75% would result in subtitles size being 75%.

Issue Labels

usability issue, visual bug

FreeTube Version

v0.21.3 Beta

Operating System Version

Windows 10 22H2

Installation Method

Portable

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

FreeTube_tkIjDtfqlZ.mp4

Nightly Build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: usability B: visual bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant