Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Reduce padding on video controls bar #5647

Closed
3 tasks done
jspast opened this issue Sep 4, 2024 · 1 comment
Closed
3 tasks done

[Feature Request]: Reduce padding on video controls bar #5647

jspast opened this issue Sep 4, 2024 · 1 comment
Labels

Comments

@jspast
Copy link

jspast commented Sep 4, 2024

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

With shaka-player introduced in #4978, there is excessive padding on the video controls bar, both on the bottom and sides. This can be shown in a comparison with the reference YouTube's official interface, and is especially noticeable when in full screen. Even with bigger fonts and icons, YouTube controls take less space on screen.

FreeTube
FreeTube

YouTube
YouTube

Full screen:

FreeTube
FreeTube full screen

YouTube
YouTube full screen

Proposed Solution

Reduce the padding so that the controls take less of the screen.

Alternatives Considered

Maybe this is intended, but it honestly doesn't look right. Also, the padding on previous FreeTube versions with video.js was closer to YouTube's.

Issue Labels

visual improvement

@efb4f5ff-1298-471a-8973-3d47447115dc

Wont implement as this layout is more accessible for all our users compared to the previous one. Keep in mind that FT is not only used on Desktop but also on TV's and phones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants