Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Make the description box collapsible #4821

Open
3 tasks done
9mdv opened this issue Mar 28, 2024 · 3 comments · May be fixed by #5665
Open
3 tasks done

[Feature Request]: Make the description box collapsible #4821

9mdv opened this issue Mar 28, 2024 · 3 comments · May be fixed by #5665
Labels
E: ease of use improvement E: new feature E: new optional setting enhancement New feature or request good first issue Good for newcomers

Comments

@9mdv
Copy link

9mdv commented Mar 28, 2024

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

The description box hijacks the scroll focus when the mouse pointer is over it. So if I wanted to go down to the comments section and my mouse pointer is over the description, it will scroll the contents of the description instead of continuing down.

Proposed Solution

Would be nice if the description box is collapsed by default or can be toggled in settings so it won't get in the way when scrolling down the page. YouTube defaults to collapsed for example:

Screenshot 2024-03-28 at 14-42-40 Life at Extremes Biology of Brine Pools and Methane Seeps - 2014 (Remastered!) Nautilus Live - YouTube

Alternatives Considered

Disable the description box in the settings, though not ideal since it contains additional information and external links related to the video you're watching.

Issue Labels

ease of use improvement, new feature, new optional setting

Additional Information

No response
@9mdv 9mdv added the enhancement New feature or request label Mar 28, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Would you like to work on making the description box collapsible by default?

@9mdv
Copy link
Author

9mdv commented Mar 29, 2024

I'd love to work on it myself but currently busy so anyone is welcome to implement if they have the time.

@kommunarr kommunarr added the good first issue Good for newcomers label Jun 24, 2024
@sabs21
Copy link

sabs21 commented Sep 8, 2024

I wrote a fix targeting the description hijacking scroll focus issue. In my fix, the video description is partially displayed (overflow set to hidden) with a new button at the bottom allowing the user to expand the description. The button that expands the description only displays when the description is long enough.

@sabs21 sabs21 linked a pull request Sep 8, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E: ease of use improvement E: new feature E: new optional setting enhancement New feature or request good first issue Good for newcomers
Projects
Feature Requests
Status: To assign
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Video description collapsible and no longer hijacks page scroll sabs21/FreeTube
4 participants
@9mdv @sabs21 @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr