Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Switching profiles does not refresh feed #6450

Closed
5 of 6 tasks
Brier1104 opened this issue Dec 24, 2024 · 7 comments
Closed
5 of 6 tasks

[Bug]: Switching profiles does not refresh feed #6450

Brier1104 opened this issue Dec 24, 2024 · 7 comments
Labels
B: feature stopped working bug Something isn't working

Comments

@Brier1104
Copy link

Brier1104 commented Dec 24, 2024

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

When changing profiles the subscription is not automatically updated. The option in Subscription Settings 'Fetch feed automatically' is selected.

This is a follow up on issue #6089.

Expected Behavior

When changing profiles the subscription is automatically updated if 'Fetch feed automatically' in subscription Settings is selected.

Issue Labels

feature stopped working

FreeTube Version

v0.22.1

Operating System Version

Windows 11 Pro

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

v0.21.3 ?

Additional Information

Screenshot 2024-12-24 170120

Nightly Build

@Brier1104 Brier1104 added the bug Something isn't working label Dec 24, 2024
@github-project-automation github-project-automation bot moved this to To assign in Bug Reports Dec 24, 2024
@kommunarr
Copy link
Collaborator

kommunarr commented Dec 24, 2024

This is a follow up on issue #6089.

How is "Switching profiles does not refresh feed" a distinct follow-up issue from "Switching profiles does not refresh feed"? Please discuss under the original issue if you think this should be counted as a bug versus an intentional byproduct of our improved caching of profiles with the same channels (e.g., switching from All Channels to another profile). Please also provide more granular information there on how to replicate it from scratch, as again, it's unclear if it's working incorrectly or "too well" such that we need to modify the requirements.

@kommunarr kommunarr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2024
@Brier1104
Copy link
Author

Maybe I'm missing something here. If so, I apologise. But, as I said above the automatic refreshing when you change to another profile is not working. If this is an intended improvement then maybe the option should be removed from Settings.

@kommunarr
Copy link
Collaborator

The problem domain is complicated by the fact that we have some pretty intricate rules related to video caching across sessions and profiles. This can lead to subscription videos not always auto-refreshing because there is recent enough video data already saved in the cache. The author of the previous issue adds on that changing profiles should not trigger a refresh if all of the channels were refreshed relatively recently, which is somewhat difficult to define in more objective terms. As I said on the other issue, this becomes the sub-issues of "is something actually broken with our caching logic and that's what some people dislike about it in certain situations","should caching be time-limited or have even more complex rules around it to have auto-refresh align with people's expectations," and/or deciding if either or both are what's going on.

@Brier1104
Copy link
Author

Thanks for the detailed explanation. Is there a large processor or bandwidth cost to always refreshing? If not, could we have it as an option?

This is my personal preference of course. I have a few profiles and each one has many active subscriptions and therefore there are always new videos being published every few minutes that I want to be notified of.

"changing profiles should not trigger a refresh if all of the channels were refreshed relatively recently"
A quick question - how long is "relatively recently" :D

~ Thanks again

@efb4f5ff-1298-471a-8973-3d47447115dc

Also one of the reason it is implemented like this is to prevent getting rate limited

@Brier1104
Copy link
Author

Is this me being rate limited?

Screenshot 2024-12-24 192402

@efb4f5ff-1298-471a-8973-3d47447115dc

No this has probably todo with being IP blocked, see #6385. Try different VPN servers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: feature stopped working bug Something isn't working
Projects
Status: To assign
Development

No branches or pull requests

3 participants