Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails don't load if the Invidious instance is behind an HTTP login #686

Closed
TheFrenchGhosty opened this issue Oct 17, 2020 · 19 comments · Fixed by #5569
Closed

Thumbnails don't load if the Invidious instance is behind an HTTP login #686

TheFrenchGhosty opened this issue Oct 17, 2020 · 19 comments · Fixed by #5569
Labels
bug Something isn't working

Comments

@TheFrenchGhosty
Copy link

TheFrenchGhosty commented Oct 17, 2020

Behavior of the program

This is an issue I reported a while back in the matrix room, but since it still happening I'm reporting it here.

If the Invidious instance used is behind a basic http login ( https://username:password@domain.ext ) , thumbnails will be broken, everything else seems to be working.

Playlists thumbnails seems to work though.

Expected behavior

Thumbnails load.

To Reproduce

Go to settings.

Set the Invidious instance to an instance behind an http login ( https://username:password@domain.ext ).

Set the preferred API backend to Invidious.

Go to any page where thumbnail are shown.

Screenshots
s

Desktop (please complete the following information):

  • OS: N/A
  • OS Version: N/A
  • FreeTube version: 0.9.0

Additional context

I can provide you an access to my instance for testing, just PM me on Matrix.

@TheFrenchGhosty TheFrenchGhosty added the bug Something isn't working label Oct 17, 2020
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented May 11, 2022

Hi @TheFrenchGhosty im wondering if this really is an issue worth solving for us because we only recommend using instances listed on https://api.invidious.io/

@TheFrenchGhosty
Copy link
Author

@efb4f5ff-1298-471a-8973-3d47447115dc This is an edge case that (mainly) affect my instance (used by a dozen or so people), I did provide an account to @PrestonN a while ago, and according to him:

"This might be a quick fix actually if I know the issue. May need to update the UI for it though."
"I think I found the issue. The thumbnails don't like having the login within the URL, so filtering them out seems to fix it."

It is worth solving in my opinion, even if it isn't a priority, because it should work (and seems to be a small bug).

@efb4f5ff-1298-471a-8973-3d47447115dc

@TheFrenchGhosty So this instance is like your private own instance right? Just curious are only the thumbnails of your videos not being loaded properly or is it also not possible for u to watch videos or search for videos?

@TheFrenchGhosty
Copy link
Author

So this instance is like your private own instance right?

It's the PussTheCat.org instance.

Yeah, only the thumbnails don't load.

@Tha14
Copy link
Contributor

Tha14 commented Mar 16, 2023

I've made some progress by adding basic http authentication for fetch in both subscriptions and invidious API and it seems to be working great so far. However, I'm unable to figure out how to fix the thumbnail problem as the images are loaded by the browser and I don't believe that there is a way to authenticate those requests programmatically. Does anyone know if it's easy to request the images with fetch, store them in the cache and load them from there instead of the instance's url?

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Feb 4, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

github-actions bot commented May 1, 2024

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants