Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically adapt theme to system preference #691

Closed
Mynacol opened this issue Oct 18, 2020 · 8 comments · Fixed by #1800
Closed

Dynamically adapt theme to system preference #691

Mynacol opened this issue Oct 18, 2020 · 8 comments · Fixed by #1800
Labels
bug Something isn't working enhancement New feature or request

Comments

@Mynacol
Copy link

Mynacol commented Oct 18, 2020

Is your feature request related to a usage problem (not a bug)? Please describe.
Most of the applications on my (Linux) system can switch between a light and dark theme. FreeTube bugs me, as it doesn't change the theme if I toggle the system-wide theme.

Describe the solution you'd like to see implemented
FreeTube should add a theme option, System, which selects a light theme if the system-wide theme is a light one and a dark theme (if dark or black could be another option) if the system has a dark theme.
This should ideally work during usage, so no restart is required to "automatically" change the theme.

Describe alternatives you've considered
I see no way to change the theme with a command line tool.
Editing theme in settings.db in the configuration directory seems to change nothing.

Screenshots
(No screenshots by me)

Additional context
I think this is the related electron manual.

@Mynacol Mynacol added the enhancement New feature or request label Oct 18, 2020
@GilgusMaximus GilgusMaximus added the bug Something isn't working label Oct 18, 2020
@gracjankn
Copy link

I hope it'll be implemented. Same applies to macOS and Windows.

@Mennaruuk
Copy link

Agreed! Switching based on system theme would be awesome.

@julianfairfax
Copy link

I'd also appreciate this feature being added. If it would follow the system theme and change to the light theme or the dark theme automatically based on what the system theme is, it would improve the integration with the system, and it would be a welcome change for me. Thanks for all the work you've put into this wonderful app!

@vallode
Copy link
Contributor

vallode commented Oct 7, 2021

I'll try to work on this tonight/tomorrow, afaik it should be a fairly simple change with a new theme preference. I don't think anyone else started work on this? Let me know.

@efb4f5ff-1298-471a-8973-3d47447115dc

U can work on this. Nobody started to work on this.

@vallode
Copy link
Contributor

vallode commented Oct 7, 2021

Quick update on this: trying to debug an issue with nativeTheme not passing down the OS preference dynamically with some electron folk. Looks like it might be a linux specific issue but I'd like to get it sorted before making a PR. Otherwise everything is pretty much sorted :)

@vallode vallode mentioned this issue Oct 8, 2021
1 task
@lothar-cell
Copy link

I'd like to see this one on MacOS too!

@f-x1-1
Copy link

f-x1-1 commented Apr 9, 2024

Additionally, You can add light/dark mode theme option, allowing users to choose built in themes for light/dark mode.

https://file.coffee/u/7yF7-eNKkGvZDa461OrY0.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants