Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key inputs doesnt fully work #766

Closed
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Nov 2, 2020 · 14 comments
Closed

Key inputs doesnt fully work #766

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Nov 2, 2020 · 14 comments
Labels
bug Something isn't working U: duplicate This issue or pull request already exists

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Behavior of the program
When watching a vid in fullscreen and u press the left right up down buttons it doenst do anything. Only after i click somewhere in the vid (for example i tap my trackpad to pause) so the player gets its first input the keys start working.

Expected behavior
Keys work without the player having the need of a first input

To Reproduce
Please add all steps to reproduce the behavior:

  1. Go to watch any video u like
  2. Click on the fullscreen button
  3. Try to use the Keys and u will see it doesnt work
  4. Click somewhere in the video to make it pause the video
  5. Try the keys and u'll that now they are working

Screenshots
None

Desktop (please complete the following information):

  • OS: [Win 10 Home]
  • OS Version: [1909]
  • FreeTube version: [0.9.2.]
  • FreeTube build: [Release]

Additional context
None
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the bug Something isn't working label Nov 2, 2020
@Svallinn
Copy link
Member

Svallinn commented Nov 2, 2020

Related to #637

@GilgusMaximus GilgusMaximus mentioned this issue Dec 30, 2020
Closed
@GilgusMaximus GilgusMaximus mentioned this issue Jun 2, 2021
Closed
@hollunder
Copy link

Another way to reproduce this is to focus FreeTube using keyboard.
Under Windows that would probably be done using ALT+TAB.
Note that this also seems to be working on and off...

@hollunder
Copy link

I guess this has something to do with keyboard vs. mouse focus and maybe keyboard controls in general.

A related annoyance is that often in fullscreen mode the space key does not pause playback but rather exits fullscreen. If that happens you can also enter fullscreen by pressing space again. I guess there might be a keyboard focus on the fullscreen toggle button.

I found that if I hit TAB in that situation then space toggles playback, which is consistent with the order you can cycle through the controls by pressing TAB. Likewise, SHIFT+TAB lets freetube toggle playback on SPACE again. The only difference is that after hitting TAB the controls in question are highlighted, which they are initially not.

Closed
Closed
3 tasks
Closed
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@Svallinn Svallinn removed the U: stale label Feb 4, 2023
@absidue absidue mentioned this issue Feb 8, 2023
Closed
5 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Open
3 tasks
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 13, 2023 •
edited
Loading

Closing in favor of #637

Duplicate of #637

@github-actions github-actions bot added the U: duplicate This issue or pull request already exists label Oct 13, 2023
@Damus765 Damus765 mentioned this issue May 13, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working U: duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hollunder @Svallinn @efb4f5ff-1298-471a-8973-3d47447115dc