Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fetch More Results" on search doesn't exclude already shown results #771

Closed
eMorph opened this issue Nov 5, 2020 · 1 comment
Closed
Labels
bug Something isn't working U: duplicate This issue or pull request already exists

Comments

@eMorph
Copy link

eMorph commented Nov 5, 2020

Behavior of the program
Upon clicking "Fetch More Results" in the search UI, it often brings up the same results as shown already, with maybe one other video.

Expected behavior
When fetching more results, if the behavior works via performing another search, that search should exclude all results already shown. If it works any other way, search results should not show more than once.

To Reproduce

  1. Go to Search
  2. Search for anything with a large amount of results
  3. Scroll down to end of results
  4. Click on "Fetch More Results"
    5: Most videos already shown at the top should be fetched again

Screenshots
Screenshot at 2020-11-05 10-38-34
Screenshot at 2020-11-05 10-39-29

Environment Information (please complete the following information):

  • OS: Fedora
  • OS Version: fc32
  • FreeTube version: 0.9.2 Beta
  • Installtion Method (If applicable): FlatHub

Additional context
This has happened both on local and Invidious, but I'm using local in these screenshots.

@eMorph eMorph added the bug Something isn't working label Nov 5, 2020
@PrestonN
Copy link
Member

PrestonN commented Nov 5, 2020

I'm going to consider this as a duplicate of #662 because part of the problem is that search isn't providing the needed information to get the next page of results.

@PrestonN PrestonN closed this as completed Nov 5, 2020
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the U: duplicate This issue or pull request already exists label Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working U: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants