Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Subtitles #847

Closed
EmeraldSnorlax opened this issue Dec 8, 2020 · 4 comments
Closed

Rich Subtitles #847

EmeraldSnorlax opened this issue Dec 8, 2020 · 4 comments
Labels
enhancement New feature or request U: duplicate This issue or pull request already exists

Comments

@EmeraldSnorlax
Copy link

EmeraldSnorlax commented Dec 8, 2020

Is your feature request related to a usage problem (not a bug)? Please describe.
Some videos have fancy / rich / coloured / special subtitles (I don't really know what they are called, sorry) and they don't get rendered properly (at all) like normal subtitles do

Describe the solution you'd like to see implemented
A way to display these fancy subtitles; if its too much time to have the full colour and positional data, falling back and drawing them as normal subtitles is fine?

Describe alternatives you've considered
Not using subtitles for that video, just displaying them as plaintext, generic subtitles as like the majority of videos

Screenshots
Here is an example video: https://youtu.be/L-MVk5I6wjo (Seems to be for all languages)
https://t89.s3-us-west-1.amazonaws.com/2020/11/MrzFzkFW/unknown.mp4 (expected output -- please note the video has audio)

@EmeraldSnorlax EmeraldSnorlax added the enhancement New feature or request label Dec 8, 2020
@EmeraldSnorlax
Copy link
Author

The subtitle data seems to be here:
http://video.google.com/timedtext?lang=en&v=L-MVk5I6wjo

@GilgusMaximus
Copy link
Contributor

GilgusMaximus commented Dec 9, 2020

Wow okay. First time I see something like this. Looks interesting.
To implement that either VideoJS has to support it natively (I'll have to check whether it does), or we would need a VideoJS plugin for that.

@EmeraldSnorlax
Copy link
Author

EmeraldSnorlax commented Jun 10, 2021

Apologies for the necro, but it now seems to be in a mostly usable state for videos like this -- while it could be be improved (sometimes the text is duplicated) its currently usable enough so feel free to close this issue if you want to (i suppose the duplication still counts as a bug?)
image

@ChunkyProgrammer
Copy link
Member

#2073 was created for the duplication issue. I will close this issue in favor of that one

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the U: duplicate This issue or pull request already exists label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request U: duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants