Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all characters of the title in one line. #857

Closed
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Dec 10, 2020 · 6 comments · Fixed by #4978
Closed

Display all characters of the title in one line. #857

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Dec 10, 2020 · 6 comments · Fixed by #4978
Labels
enhancement New feature or request

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 10, 2020

I also checked what the max character length is of a YT vid and it is 100(including spaces), i searched a vid with max characters and this is what i got.

Screenshot (10)

Now that we know that this is the max length of characters, i think it is better to resize the font to fit all the characters so this wont happen again.

This is the link to that vid:
https://youtu.be/YkL3P0p_wMk

There are also people that abuse Unicode characters in video titles like this one 𒐫 (this is one character) and paste it 100times. YT just cuts the spam of characters off in full screen and replaces it with ... if it gets too long. We also need that in place.

Screenshot (11)

Edit: After some investigation i found out that the widest character on a standard keyboard is the '@'.

Now u can paste 100 characters next to each other to see how much u need to resize the font. I hope the font doesnt get too small.

Optional: Find out what characters are the widest in foreign languages such as Mandarin, Arabic, Hindi and compare them to the widest character of a standard keyboard.
If the character of a foreign language is wider then the widest character of a standard keyboard.
Resize the font.

2nd Optional: Do the first option but then with emoji's.

@GilgusMaximus
Copy link
Contributor

Thanks for creating a new issue.
So for the visibility of the video title, a simple solution like adding a black border around the text would be an easy fix.
Because recognizing where the video is light and dark for all characters could slow down the app significantly for every frame of the video.
Another possibility would be to add a medium transparent darker overlay on the top of the video, similar to YouTube. This allows the white text to be visible at any time as well.

Regarding the font size, this should be taken into account

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

The Youtube kind of solution sounds better then putting a black border around it.
Because if the border is in place, i can imagine a few scenario's where u won't see the title (but this is just speculation).

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

Is it possible to implement the same solution that is used for the mediabar in fullscreen?
Everything in there is white just like the title and that doesn't disappear.

@GilgusMaximus
Copy link
Contributor

From what I think it was implemented, we should be able to change the background color of the text field. But I'd have to look more into this. Unfortunately I'm currently quite busy.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

@GilgusMaximus i noticed i put multiple problems into this one issue. Do u think its better to split them up in separate issues.
It would look something like this:

  1. Title is not visible in fullscreen when a white background is being displayed.
  2. Display all characters of the title in one line.

@GilgusMaximus
Copy link
Contributor

Good idea. I'd change this issue to 'Title not visible on white background videos' and open a new one for the long video titles.

Thanks for checking the old issues for multiple requests, appreciate it :)

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc changed the title Title of vid in fullscreen v2 Display all characters of the title in one line. Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants