Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Trending page won't load when using a European IP address #11

Closed
ChunkyProgrammer opened this issue Mar 26, 2022 · 7 comments
Closed

Trending page won't load when using a European IP address #11

ChunkyProgrammer opened this issue Mar 26, 2022 · 7 comments

Comments

@ChunkyProgrammer
Copy link
Member

ChunkyProgrammer commented Mar 26, 2022

I believe it's a "Cookie consent verification" required issue
FreeTubeApp/FreeTube#2125 (comment)

I believe the solution would be something like this

https://github.com/FreeTubeApp/yt-comment-scraper/blob/ff0c885de2053ef92d80e26d4861a9b7cc634986/src/HttpRequester.js#L20

@efb4f5ff-1298-471a-8973-3d47447115dc

This should be fixed now.

@ChunkyProgrammer
Copy link
Member Author

It's fixed when using FreeTube but not fixed for other people that use the module

@GilgusMaximus
Copy link
Contributor

Mhh, for me running all the tests, gives me failure of the following ones.
image

I also manually checked the returned data of the normal requests, but it seems that it is working form my German ip. Do all of these work at least in FreeTube?

@ChunkyProgrammer
Copy link
Member Author

Mhh, for me running all the tests, gives me failure of the following ones. image

I also manually checked the returned data of the normal requests, but it seems that it is working form my German ip. Do all of these work at least in FreeTube?

I believe this is working in FreeTube now as the consent cookie is set in the app (see FreeTubeApp/FreeTube#2316).

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Jul 4, 2022

seems to be an issue with the shorts regex and not an issue with European IP addresses. I think it's a case of correlation != causation FreeTubeApp/FreeTube#2125 (comment)

@ChunkyProgrammer
Copy link
Member Author

see #17

@GilgusMaximus
Copy link
Contributor

GilgusMaximus commented Jul 5, 2022

Okay so I investigated a bit further on #17 , I run into the problem because the module gets me everything in German, so the regex for English time units doesn't work. I identified the following cookie to determine the language at the end for me, but setting it like below doesn't change it for me.

image

Update:
Just realized, it fails on the Gaming page because there is a short video in the list like a normal video and there it fails due to the language incompatibility. Same then for the parseCreator on the rise as then all the shorts are parsed:
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants