-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links that look like buttons but shouldn't #591
Comments
Description written. Will work on a gallery of possible link styles, with no promises as to time frame! |
@AlOneill have you had any ideas about possible link styles? Hoping we could sort this in time for FreeBMD2 MVP release (which we are edging ever closer to) |
My main thought is still to put back the underlining — it is now more targetted which does not compromise legibility. Images for BMD to follow. It will be a fairly big task to write and check the SCSS — the changes will be complicated (but not complex) by those situations where underlining is very likely not to be required: the main menu, for example. |
It could, if we want, be styled differently from the main menu bar. We already have the situation where one of the main menu items ('Logout') isn't strictly speaking a link, but instead triggers a state change. Similarly the 'download' links don't take you away from the current page, but instead create and download a file to the user's machine. Personally I think this mix of actions, state changes and links is OK, but others might disagree. |
Style now in Beta BMD2 on Results page (awaiting fix on space between icons and text, and View links in table styling). Feedback welcome! |
Why is it a mistake to make links look like buttons?
Four good reasons for not confusing our users by making links look like buttons or buttons look like links.
Yes, sometimes our current link styling is not prominent enough to attract a user's attention — making a link look like a button is not the answer. Now that the underlining of links is more flexible (and there are other ways of putting a line underneath a link), we cannot use the original deficiencies of text-decoration: underline; as a valid reason for making links look like buttons. For example,
text-decoration: underline;
now skips descenders and it is possible to make the colour of the line different from that of the text.Putting the paragraph containing the link into a CSS island or islet is another way to increase its prominence — see the About page of any of our projects for an example of this technique. NB for obvious reasons, it must be the whole paragraph and not just the link.
The text was updated successfully, but these errors were encountered: