Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to file issues against linux-fslc? #1406

Closed
otavio opened this issue Feb 3, 2023 Discussed in #1404 · 11 comments
Closed

Where to file issues against linux-fslc? #1406

otavio opened this issue Feb 3, 2023 Discussed in #1404 · 11 comments

Comments

@otavio
Copy link
Member

otavio commented Feb 3, 2023

Discussed in #1404

Originally posted by jaskij February 2, 2023
I'm not sure where to go - linux-fslc has issues and discussions disabled.

I have found an issue specific to linux-fslc (not present in same version mainline) and have no idea where to send information about it.


Noting the info down so it doesn't get lost:

add_one_port() is called twice in lpuart_probe(), here:

https://github.com/Freescale/linux-fslc/blob/3ff5eb3ff57e665c47c072284d7f624e5452b85d/drivers/tty/serial/fsl_lpuart.c#L2965-L2986

Removing the second call seems to fix the issue (system has booted with console past the point, but I have not done extensive testing).

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index a12ff4954793..75e906c467d8 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2981,10 +2981,6 @@ static int lpuart_probe(struct platform_device *pdev)
 	    sport->port.rs485.delay_rts_after_send)
 		dev_err(&pdev->dev, "driver doesn't support RTS delays\n");
 
-	ret = uart_add_one_port(&lpuart_reg, &sport->port);
-	if (ret)
-		goto failed_attach_port;
-
 	ret = devm_request_irq(&pdev->dev, sport->port.irq, handler, 0,
 				DRIVER_NAME, sport);
 	if (ret)
```</div>
@otavio
Copy link
Member Author

otavio commented Feb 3, 2023

@jaskij, which kernel version is this?

@angolini did the last kernel stable release merges.

@jaskij
Copy link

jaskij commented Feb 3, 2023

Ah, sorry. 5.15 as present in Kirkstone.

@jaskij
Copy link

jaskij commented Feb 3, 2023

@otavio does this mean that meta-freescale is the correct place for issues specific to linux-fslc?

@otavio
Copy link
Member Author

otavio commented Feb 3, 2023

No, it is https://github.com/Freescale/linux-fslc. Are you keen to open a PR?

@otavio
Copy link
Member Author

otavio commented Feb 3, 2023

@jaskij, to avoid confusion. The preferred place to report issues is https://github.com/Freescale/linux-fslc as well as PRs.

That said, all contribution is welcome 👍🏼

@jaskij
Copy link

jaskij commented Feb 3, 2023

@otavio the problem is, I can not create an issue in that repo - the tab is not shown to me at all. That's why I started a discussion here.

@otavio
Copy link
Member Author

otavio commented Feb 3, 2023

Ouch! Fixed.

@MrCry0
Copy link
Contributor

MrCry0 commented Feb 3, 2023

Freescale/linux-fslc#621

@otavio
Copy link
Member Author

otavio commented Feb 3, 2023

@MrCry0 merged. Can you bump the kernel?

@MrCry0
Copy link
Contributor

MrCry0 commented Feb 3, 2023

@otavio sure! done: #1408

@otavio
Copy link
Member Author

otavio commented Feb 3, 2023

Merged.

@otavio otavio closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants