changed early return

connorhu · thePanz · web-flow · commit 455e001b51b5 · 2024-03-21T10:05:01.000+01:00
Co-authored-by: Emanuele Panzeri &lt;thepanz@gmail.com&gt;
diff --git a/lib/view/sfViewCacheManager.class.php b/lib/view/sfViewCacheManager.class.php
@@ -439,11 +439,11 @@ public function remove($internalUri, $hostName = '', $vary = '', $contextualPref
         if (strpos($cacheKey, '*')) {
             return $this->cache->removePattern($cacheKey);
         }
-        if ($this->cache->has($cacheKey)) {
-            return $this->cache->remove($cacheKey);
+        if (!$this->cache->has($cacheKey)) {
+            return true;
         }
 
-        return true;
+        return $this->cache->remove($cacheKey);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -439,11 +439,11 @@ public function remove($internalUri, $hostName = '', $vary = '', $contextualPref`
`439`	`439`	`if (strpos($cacheKey, '*')) {`
`440`	`440`	`return $this->cache->removePattern($cacheKey);`
`441`	`441`	`}`
`442`		`- if ($this->cache->has($cacheKey)) {`
`443`		`- return $this->cache->remove($cacheKey);`
	`442`	`+ if (!$this->cache->has($cacheKey)) {`
	`443`	`+ return true;`
`444`	`444`	`}`
`445`	`445`
`446`		`- return true;`
	`446`	`+ return $this->cache->remove($cacheKey);`
`447`	`447`	`}`
`448`	`448`
`449`	`449`	`/**`