Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UUID definition from Implementing Class #172

Open
ivanpointer opened this issue Aug 6, 2021 · 2 comments
Open

Allow UUID definition from Implementing Class #172

ivanpointer opened this issue Aug 6, 2021 · 2 comments

Comments

@ivanpointer
Copy link

Is your feature request related to a problem? Please describe.
No - just an annoyance.

Describe the solution you'd like
I'd like to be able to use either the ActionUuidAttribute or a solution that allows for runtime values; The attribute can only be instantiated with compile-time values (naturally). Perhaps an overload on a property the BaseStreamDeckAction base class to specify the UUID for the action? (I'm not sure, I haven't dug into the code yet - I'm not sure if an instance of the action is available when the UUID is needed).

Describe alternatives you've considered
See above.

Additional context
I'll be forking this repo to create a potential solution. I'll submit a PR from my fork to this repo (if I can). If no, I'll respond back in this issue with a link to the PR within my fork to show what I end up with...

** Is there one or more bugs reported related to this suggestion? If so, mention them below***
No.

@ivanpointer
Copy link
Author

The "sister" issue to this in my fork is: ivanpointer#1

@ivanpointer
Copy link
Author

PR Submitted: #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant