Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project.name contains an illegal character #132

Closed
1 task done
Laikulo opened this issue Jun 24, 2024 · 2 comments · Fixed by #136
Closed
1 task done

project.name contains an illegal character #132

Laikulo opened this issue Jun 24, 2024 · 2 comments · Fixed by #136
Labels
bug Something isn't working

Comments

@Laikulo
Copy link
Contributor

Laikulo commented Jun 24, 2024

K-Shake&Tune module branch

  • I confirm using the main branch

Version

N/A

Describe the bug and expected behavior

The project.name specified in pyproject.toml contains an amperstand.

name = "Shake&Tune"

Names must begin/end with an alphanumeric, and may contain dots, hyphens, and underscores in other positions (https://peps.python.org/pep-0508/)

identifier_end = letterOrDigit | (('-' | '_' | '.' )* letterOrDigit)
identifier    = letterOrDigit identifier_end*
name          = identifier

Additional information and klippy.log

No response

@Laikulo Laikulo added the bug Something isn't working label Jun 24, 2024
@Laikulo
Copy link
Contributor Author

Laikulo commented Jun 24, 2024

(this breaks some other tooling in the python ecosystem, I found this initially on this fork (where I toss it unceremoniously in to a wheel), but it is also present on main)

https://github.com/Laikulo/shaketune/tree/packaged

@Frix-x
Copy link
Owner

Frix-x commented Jun 27, 2024

Thanks for raising it. I think it's not problematic in the current state of S&T since I don't really use this field currently. But I'll fix it to make it more clean :)

@Frix-x Frix-x linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants