-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adler
is archived
#148
Comments
Hm. I don't know whether this is an issue or not. There aren't really any alternatives atm as simd-adler32 uses unsafe (due to the use of manual SIMD code) hence why it's an optional feature, and the reason we moved to the adler crate from adler32 originally was due to licensing differences. (The adler32 git has it's last update even further back.) I guess we'd need to fork it or ask if it would be possible to take over the crate or something if an update is be needed. Judging by the benches at the simd-adler32 page it's possible there are some performance improvements that could be done even if explicit SIMD can't be used due to unsafe. (ofc using the simd feature which uses simd-adler32 will speed up things more if that's important, and one is using the zlib wrapper specifically.) For that matter miniz_oxide could probably benefit being moved/transfered to an org or something as well as I'm basically the sole maintainer currently, not sure if @Frommi is accessible these days. |
I've mentioned this issue and general problem at rustsec/advisory-db#1992 |
Should this be closed now, as it seems like adler2 is being depended on? |
Yup, just forgot to add it to the commits |
As of yesterday, it seems: https://github.com/jonas-schievink/adler
EDIT:
adler
is relied upon here:miniz_oxide/miniz_oxide/Cargo.toml
Line 20 in 79307d7
The text was updated successfully, but these errors were encountered: