Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adler is archived #148

Closed
smoelius opened this issue Mar 26, 2024 · 5 comments
Closed

adler is archived #148

smoelius opened this issue Mar 26, 2024 · 5 comments

Comments

@smoelius
Copy link

smoelius commented Mar 26, 2024

As of yesterday, it seems: https://github.com/jonas-schievink/adler

EDIT: adler is relied upon here:

adler = { version = "1.0", default-features = false }

@oyvindln
Copy link
Collaborator

Hm. I don't know whether this is an issue or not. There aren't really any alternatives atm as simd-adler32 uses unsafe (due to the use of manual SIMD code) hence why it's an optional feature, and the reason we moved to the adler crate from adler32 originally was due to licensing differences. (The adler32 git has it's last update even further back.)

I guess we'd need to fork it or ask if it would be possible to take over the crate or something if an update is be needed. Judging by the benches at the simd-adler32 page it's possible there are some performance improvements that could be done even if explicit SIMD can't be used due to unsafe. (ofc using the simd feature which uses simd-adler32 will speed up things more if that's important, and one is using the zlib wrapper specifically.)

For that matter miniz_oxide could probably benefit being moved/transfered to an org or something as well as I'm basically the sole maintainer currently, not sure if @Frommi is accessible these days.

@smoelius
Copy link
Author

smoelius commented Apr 2, 2024

For that matter miniz_oxide could probably benefit being moved/transfered to an org or something

FWIW, miniz_oxide appears in my projects' dependency trees under anyhow >> backtrace and gix >> ... >> flate2.

... I'm basically the sole maintainer currently ...

Thank you for that! 🙏

@jayvdb
Copy link

jayvdb commented Jul 3, 2024

I've mentioned this issue and general problem at rustsec/advisory-db#1992

@GnomedDev
Copy link
Contributor

Should this be closed now, as it seems like adler2 is being depended on?

@oyvindln
Copy link
Collaborator

Yup, just forgot to add it to the commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants