Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up adler32 #76

Closed
Shnatsel opened this issue Apr 13, 2020 · 2 comments
Closed

Speed up adler32 #76

Shnatsel opened this issue Apr 13, 2020 · 2 comments

Comments

@Shnatsel
Copy link
Contributor

When decoding lightly compressed data the majority of the time is spent in adler32::RollingAdler32::update_buffer, so even small speedups in it will translate to measurable speeupds in the entire decoding.

Profiling results from miniz-oxide branch of png crate to back this up: https://perfht.ml/2V3ml3q
@Shnatsel
Copy link
Contributor Author

This has been encountered in other languages as well, and steps taken to optimize (non-Rust) implementations. See e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=762564

@Shnatsel
Copy link
Contributor Author

I've looked into adler32 crate and it's already heavily optimized - seemingly to the extent of what's possible without explicit SIMD, so closing this as infeasible.

@Shnatsel Shnatsel mentioned this issue Jul 4, 2020
Merged
@Shnatsel Shnatsel mentioned this issue Nov 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shnatsel