Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide option to opt out of fedora-review-service #24

Open
penguinpee opened this issue May 18, 2023 · 1 comment · May be fixed by #48
Open

Provide option to opt out of fedora-review-service #24

penguinpee opened this issue May 18, 2023 · 1 comment · May be fixed by #48
Labels
effort/medium Can be done in 1-2 days gain/medium Affects multiple users

Comments

@penguinpee
Copy link

penguinpee commented May 18, 2023 •
edited
Loading

I already build all my packages I submit for review in Copr, precisely because I find the the fedora-review option very handy for detecting issues before submitting the package for review.

Therefore, it feels redundant that fedora-review-service does the same again. An option to disable fedora-review-service would allow users to opt out. Something similar to explicitly triggering it like [fedora-review-service-skip] or [fedora-review-service-opt-out] added in a comment would be most convenient. Maybe a specific string in Whiteboard or Personal tags could also work. That remains unchanged when submitting updates throughout the review process.

Another use case where one may want to opt out is when a package needs bootstrapping. I encountered that when reviewing some low level python mingw packages a while ago.
@FrostyX FrostyX added gain/medium Affects multiple users effort/medium Can be done in 1-2 days labels Nov 29, 2023
@ppfeister
Copy link

+1

Came to the repo to make this very suggestion. As an added use case (my use case)...

My SRPM link died and needed replacing. Simple minor update (no email) with the new link, no other changes made and no build necessary.

Would be nice to have this option for minor updates like this, so the build doesn't trigger and send emails to everyone or add noise to the message history.

@ppfeister ppfeister linked a pull request May 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/medium Can be done in 1-2 days gain/medium Affects multiple users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add keyword to opt out of automatic builds ppfeister/fedora-review-service
3 participants
@FrostyX @ppfeister @penguinpee