Allowing smiley (or frowny) faces when preceded by : in strict mode

[dakrone]

I think it would be great if smartparens' strict-mode would detect that a smiley or frowny face was being inserted and still allow it in certain modes.

For instance, in email composing modes, it's quite common that I'll have (| indicates cursor position):

Have a nice day :|

And then type ) only to receive We can not insert unbalanced closing delimiter in strict mode.

Or, alternatively:

That stinks :|

And type ( only to get:

That stinks :()

Which can be confusing if I don't catch it :)

[Fuco1]

:D I've had a feature request for this in my notes for good 3 years now, but then I stopped using ert for irc and just somehow abandoned the idea.

I think it would be nice in text modes, emails and similar. Could you maybe compile a list of modes where this bothers you, then I'll add mine and we can cook something up. Or maybe just add all text-mode derived modes?

I'll leave this up for a discussion for a bit, but I'm definitely all for this.

[Fuco1]

Implementation-wise, it should be enough to add a filter on the pair to disable the check if certain pairs are preceded by the colon, so if someone wants to start PR right away, I won't get mad :P

[dakrone]

Could you maybe compile a list of modes where this bothers you

Sure, it's mostly in emails mu4e-compose-mode, message-mode, and erc-mode for IRC, as well as whatever mode twittering uses for composing tweets (I'm not sure what major mode that is).

Other than that I can deal with it, those are the big ones

[Fuco1]

Note: this might be a great use-case for the new feature of named-configuration sets: http://smartparens.readthedocs.io/en/latest/pair-management.html#named-pair-definitions-buffer-local

[Fuco1]

Wow, so I've decided to implement this feature and it led me down the slippery slope of having to rewrite half the balance checking routines, during which I've discovered several bugs (#774 being one of the more serious). Good stuff.

Anyway, I almost have it sorted out so expect this to land soon :)

[dakrone]

Thanks for fixing this @Fuco1!