Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending block, used gas estimation, dry run #129

Closed
rakita opened this issue Jan 11, 2022 · 3 comments
Closed

Pending block, used gas estimation, dry run #129

rakita opened this issue Jan 11, 2022 · 3 comments
Labels
graphql-api Affects API of the GraphQL question Further information is requested

Comments

@rakita
Copy link
Contributor

rakita commented Jan 11, 2022

txpool submit as Brandon said should return the result of tx inclusion inside txpool. When somebody wants to submit a signed transaction it needs to be sure that the transaction is already checked and with submit the user tell us it's the intention to commit, it is mostly a point of no return because tx is going to be broadcasted to the network.

There is an idea of the pending block, where the Block producer will every N second take best T transactions and with its best ability create pending block so that users know what to expect (this is just usability, it shouldn't have any effect on consensus) and can inspect executed transactions.

There should be the ability to dry run tx (or maybe even a list of tx if they are dependent) so that users can see gas used and calculate the gas limit. Dry run over the pending block or dry run over the best block. This can be even extended to: with this gas_price where is this transaction going to land inside the block and what amount of gas is going to be used, there are some MEV vibes here but seems like a topic for the future.

@Voxelot
Copy link
Member

Voxelot commented Feb 25, 2022

@rakita we already have a dry-run interface, we should either clearly specify the improvements needed or close this issue.

@Voxelot Voxelot added the question Further information is requested label Feb 25, 2022
@rakita
Copy link
Contributor Author

rakita commented Feb 25, 2022

This is different, it gives you best guess on next block that is going to be created and it better reflects changes that are going to be merged into canon chain.
dry-run is still needed for gas estimations, testing, getters etc.. but this dry-run is agains pending block not agains best known block, and user can chose if he want pending, best or past block to dry-run agains.

@xgreenx
Copy link
Collaborator

xgreenx commented May 14, 2024

Close in favour of #1206

@xgreenx xgreenx closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql-api Affects API of the GraphQL question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants