Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS KMS as a way to sign block in the fuel-core #2043

Closed
xgreenx opened this issue Jul 23, 2024 · 1 comment · Fixed by #2051
Closed

Add support for AWS KMS as a way to sign block in the fuel-core #2043

xgreenx opened this issue Jul 23, 2024 · 1 comment · Fixed by #2051
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jul 23, 2024

Overview

We need to add an ability to sign blocks with AWS KMS.

Implementation details

Use aws-sdk-kms crate for adding support for the PoA service to use AWS KMS to sign blocks.

It requires updating the CLI argument to pass a private key. It should be either a raw private key or credentials for KMS.

It would be nice to abstract the signing of the block via some trait and have different backed for signing. The sign function could be async.

Testing details

Please check the https://fuellabs.slack.com/archives/C0298A7TT1C/p1720046999839619 thread for test credentials to test the change with a real cluster.

@Dentosal
Copy link
Member

Dentosal commented Jul 31, 2024

Open questions:

  • Should we allow passing in the configuration in any other way than just loading from the environment, i.e. with aws_config::load_from_env
    • Should we lock ourselves to a specific version of this config, or always use the latest availble defaults?
  • Should we have this all behind an opt-out feature flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants