Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iterators): return slice of key instead of a vec #2097

Closed
rymnc opened this issue Aug 17, 2024 · 1 comment
Closed

chore(iterators): return slice of key instead of a vec #2097

rymnc opened this issue Aug 17, 2024 · 1 comment

Comments

@rymnc
Copy link
Member

rymnc commented Aug 17, 2024

reference: #2092 (comment)

As per @xgreenx's comment, we should investigate if there is a clean way to return a slice of the key instead of an owned vec

@xgreenx
Copy link
Collaborator

xgreenx commented Aug 27, 2024

I think it is not possible since we call next on the iterator that requires &mut. Plus I assume that underlying iterator will deallocate the memory, so we can close this issue=)

@xgreenx xgreenx closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants