Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast transactions to peers when they're inserted into txpool via GraphQL API #477

Closed
Tracked by #479
bvrooman opened this issue Jul 11, 2022 · 0 comments · Fixed by #491 or #590
Closed
Tracked by #479

Broadcast transactions to peers when they're inserted into txpool via GraphQL API #477

bvrooman opened this issue Jul 11, 2022 · 0 comments · Fixed by #491 or #590
Assignees
@bvrooman @ControlCplusControlV
Labels
enhancement New feature or request fuel-txpool

Comments

@bvrooman
Copy link
Contributor

bvrooman commented Jul 11, 2022 •
edited by Voxelot
Loading

There are two halves for implementing the share txs feature, broadcast and receiving. This task is only for tracking the broadcast side of this effort.

Expected Test Coverage for completion:

  • GrapqhQL API testing of fuel-core to ensure a proper TransactionBroadcast::NewTx event is sent when a tx is submitted via GraphQL, only after it is successfully included in the transaction pool.
  • Transactions directly inserted into the txpool do not emit a NewTx event, to ensure no feedback loop happens when receiving txs.
@bvrooman bvrooman added enhancement New feature or request fuel-txpool labels Jul 11, 2022
@Voxelot Voxelot changed the title Integrate p2p TransactionBroadcast in txpool to share txs Broadcast transactions to peers when they're inserted into txpool via GraphQL API Jul 11, 2022
@Voxelot Voxelot mentioned this issue Jul 11, 2022
Closed
6 tasks
Merged
@Voxelot Voxelot moved this from Todo to In Progress in Fuel Network Jul 15, 2022
@Voxelot Voxelot moved this to Todo in Fuel Network Jul 15, 2022
@ControlCplusControlV ControlCplusControlV mentioned this issue Sep 4, 2022
Merged
Repository owner moved this from In Progress to Done in Fuel Network Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvrooman bvrooman

@ControlCplusControlV ControlCplusControlV

Labels
enhancement New feature or request fuel-txpool
Projects
Fuel Network
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Controlc/tx p2p FuelLabs/fuel-core
Connect P2p with TxPool FuelLabs/fuel-core
2 participants
@bvrooman @ControlCplusControlV