Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify names of our mpsc channels #556

Closed
leviathanbeak opened this issue Aug 11, 2022 · 2 comments
Closed

Unify names of our mpsc channels #556

leviathanbeak opened this issue Aug 11, 2022 · 2 comments
Labels
good first issue Good for newcomers tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@leviathanbeak
Copy link
Contributor

leviathanbeak commented Aug 11, 2022

While #492 has not yet been merged, in it we use rx and tx prefixes when naming our Sender and Receiver channels.
An example would be rx_request_event.

In other modules, channel names do not follow that convention, even worse (imo) they are too vague as:
sender, broadcast, receive etc

I would like us to have more meaningful and unified channel names.
I propose rx/tx prefixes + descriptive name, but I am open to other ideas as well.

@leviathanbeak leviathanbeak added good first issue Good for newcomers tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. labels Aug 11, 2022
@leviathanbeak leviathanbeak moved this to Todo in Fuel Network Aug 11, 2022
@Dentosal
Copy link
Member

This is otherwise nice, but unfortunately tx is used for transaction in many contexts, which might be confusing.

@Voxelot
Copy link
Member

Voxelot commented Jan 4, 2023

closing as the channels have been largely removed during the architecture migration

@Voxelot Voxelot closed this as completed Jan 4, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Fuel Network Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
Status: Done
Development

No branches or pull requests

3 participants