Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuel-P2P Metrics #808

Closed
3 tasks
ControlCplusControlV opened this issue Dec 1, 2022 · 3 comments
Closed
3 tasks

Fuel-P2P Metrics #808

ControlCplusControlV opened this issue Dec 1, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@ControlCplusControlV
Copy link
Contributor

Also look at gossipsub metrics config and use real parameters

Fuel-p2p

  • - Track maybe amount of p2p messages
  • - Unique peers connected to
  • - Track Transactions from peers
@AurelienFT
Copy link
Contributor

@rafal-ch can we consider this as done or there is more things to add ?

@rafal-ch
Copy link
Contributor

rafal-ch commented Oct 22, 2024

@rafal-ch can we consider this as done or there is more things to add ?

I'm not sure, tbh. @rymnc added quite a lot of P2P metrics in this commit, but they seem to be more "low-level" than the ones mentioned in the description. For example, I don't see a metric for "Track Transactions from peers".

We should double-check with @rymnc or discuss on the grooming.

@rymnc
Copy link
Member

rymnc commented Oct 22, 2024

we can close this issue as p2p metrics have been added and transactions are tracked via txpool metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants