Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: Assess arithmetic safety of fuel-merkle crate #491

Open
xgreenx opened this issue Jun 13, 2023 · 2 comments
Open

Investigate: Assess arithmetic safety of fuel-merkle crate #491

xgreenx opened this issue Jun 13, 2023 · 2 comments
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jun 13, 2023

FuelLabs/fuel-merkle#124

@Dentosal
Copy link
Member

Dentosal commented May 6, 2024

Mostly addressed in #729

From the original issue there's still:

  • Limit leaves_count to 2^63 for push and load operations

Which seems like a non-issue, as a it's physically impossible to have enough memory to for trees of that magnitude.

@MitchTurner
Copy link
Member

We will be creating the new implementation, so maybe we can just add this lint from the conception of the new new library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants