Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround placed to handle temporary mandatory arguments #13

Closed
digorithm opened this issue Nov 30, 2021 · 3 comments · Fixed by #150
Closed

Remove workaround placed to handle temporary mandatory arguments #13

digorithm opened this issue Nov 30, 2021 · 3 comments · Fixed by #150
Assignees
@iqdecay
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@digorithm
Copy link
Member

As discussed in #11 (comment), once the Sway compiler removes the need to have gas, color, and coin amount as mandatory arguments to every ABI method, we should go back to this place in the fuels-rs code and remove the workaround.
@digorithm digorithm added the enhancement New feature or request label Nov 30, 2021
@digorithm digorithm mentioned this issue Nov 30, 2021
Merged
@digorithm digorithm added the good first issue Good for newcomers label Jan 4, 2022
@digorithm digorithm moved this to Todo in Fuel Network Jan 6, 2022
@iqdecay iqdecay moved this from Todo to In Progress in Fuel Network Jan 18, 2022
@iqdecay iqdecay assigned iqdecay and unassigned iqdecay Jan 18, 2022
@iqdecay iqdecay moved this from In Progress to Todo in Fuel Network Jan 18, 2022
@iqdecay iqdecay mentioned this issue Feb 6, 2022
Merged
@adlerjohn
Copy link
Contributor

We can tackle this after FuelLabs/sway#859 lands and a new release of the compiler is cut

@adlerjohn
Copy link
Contributor

FuelLabs/sway#859 has been merged, so we only need a new release of the compiler.

@iqdecay
Copy link
Contributor

iqdecay commented Mar 9, 2022 •
edited
Loading

Compiler was updated to 0.6 by FuelLabs/sway#897

@iqdecay iqdecay self-assigned this Mar 9, 2022
This was referenced Mar 10, 2022
Closed
Merged
@digorithm digorithm mentioned this issue Mar 11, 2022
Merged
Repository owner moved this from Todo to Done in Fuel Network Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iqdecay iqdecay

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes to support forc 0.6 FuelLabs/fuels-rs
3 participants
@adlerjohn @digorithm @iqdecay