Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new flat JSON ABI file format #525

Closed
5 tasks done
digorithm opened this issue Aug 10, 2022 · 0 comments · Fixed by #533
Closed
5 tasks done

Support the new flat JSON ABI file format #525

digorithm opened this issue Aug 10, 2022 · 0 comments · Fixed by #533
Assignees
Labels
big enhancement New feature or request

Comments

@digorithm
Copy link
Member

digorithm commented Aug 10, 2022

To support generics, Vec, and more, a lot of effort went into redesigning the JSON ABI file format; the discussion can be found here.

We have a couple of hand-made examples already, so both teams (SDK and Compiler) can work on it in parallel.

This issue tracks this support. Tasks:

  • Create an alternate path for the abigen to support both file formats while we make the transition;
  • In the new path, generate functions and function selectors based on the new format;
  • In the new path, generate the custom types based on the new format;
  • Run tests with all hand-made examples;
  • Once the compiler outputs the new file format, replace the original abigen with the new one and make necessary adjustments.

Once this is done and we have feature parity between the old and new format, we can start adding support for generics and other newer features.

@digorithm digorithm added enhancement New feature or request big labels Aug 10, 2022
@digorithm digorithm self-assigned this Aug 10, 2022
@digorithm digorithm moved this to Todo in Fuel Network Aug 10, 2022
@digorithm digorithm moved this from Todo to In Progress in Fuel Network Aug 10, 2022
Repository owner moved this from In Progress to Done in Fuel Network Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant