Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly format fuels dev terminal output in a helpful way #2012

Open
Dhaiwat10 opened this issue Apr 4, 2024 · 3 comments
Open

Properly format fuels dev terminal output in a helpful way #2012

Dhaiwat10 opened this issue Apr 4, 2024 · 3 comments
Labels
feat Issue is a feature

Comments

@Dhaiwat10
Copy link
Member

Currently, the fuels dev command outputs everything that the node outputs plus some small messages which can be easily missed.

This makes it very difficult for devs to find logs, and figure out what exactly is happening in their terminal window.

We should log out only the important details like when a tx happens, when a contract is deployed, etc. And hide the rest of the details under a --verbose flag.

@Dhaiwat10 Dhaiwat10 added the feat Issue is a feature label Apr 4, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Apr 5, 2024
@arboleya
Copy link
Member

arboleya commented Apr 6, 2024

Hmm, I don't know about this one. The more we hide, the more we abstract. As we start deciding what logs to show on behalf of the fuel-core (instead of just piping them through), we may enter dangerous/opinionated territory.

I'd consider thinking this through and [maybe] adding suggestions on the fuel-core repo.

@Dhaiwat10
Copy link
Member Author

hmm. Maybe we can just do this abstraction for create fuels then? We can hide the abstraction behind a verbose flag like I mentioned, but I think this abstraction is gonna be very helpful for people building dApps who need a good, easy-to-read feedback loop when building a fullstack dApp. Right now they see a thousand long messages which are very hard to see through and figure out what exactly happened.

Thoughts? @arboleya

@arboleya
Copy link
Member

arboleya commented Apr 11, 2024

I believe fuel-core logs are irrelevant for the create-fuels CLI but essential for the fuels dev command.

We should not try to improve fuel-core stuff in the fuels CLI, no matter how tempting that may be.

@arboleya arboleya modified the milestones: Caterpillar, 1.0 caterpillar, 0.x post-launch Jun 9, 2024
@Dhaiwat10 Dhaiwat10 removed their assignment Jul 17, 2024
@arboleya arboleya added p2 and removed p1 labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@arboleya arboleya removed the p2 label Jul 19, 2024
@arboleya arboleya removed the blocked label Sep 7, 2024
@arboleya arboleya added the temp:notion label Sep 8, 2024 — with Linear
@arboleya arboleya added the temp-linear label Sep 8, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

No branches or pull requests

2 participants