feat: fuelup completions #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some working screenshots: |
eightfilms
suggested changes
Nov 29, 2022
| @@ -137,7 +137,7 @@ main() { | |||
| ignore rmdir "$_dir" | |||
|
|
|||
| printf '\n' | |||
| printf '%s\n' "fuelup ${_fuelup_version} has been installed in $FUELUP_DIR/bin. To fetch the latest toolchain containing the forc and fuel-core binaries, run 'fuelup toolchain install latest'." 1>&2 | |||
| printf '%s\n' "fuelup ${_fuelup_version} has been installed in $FUELUP_DIR/bin. To fetch the latest toolchain containing the forc and fuel-core binaries, run 'fuelup toolchain install latest'. To generate completions for your shell, run 'fuelup completions --shell=SHELL'." 1>&2 | |||
There was a problem hiding this comment.
To generate completions for your shell, run 'fuelup completions --shell=SHELL
It would be great if this instruction, along with a short description, is also included within the fuelup book, perhaps under the Configuration chapter?
There was a problem hiding this comment.
didn't realise that the book is also in this repo
will add some instructions
added 2 commits
November 29, 2022 10:55
|
hi @bingcicle, thanks for your suggestions, i've updated accordingly (book content for |
eightfilms
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291.