Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the problem with OrdEq discovered during #1600 #1667

Open
otrho opened this issue May 25, 2022 · 4 comments
Open

Address the problem with OrdEq discovered during #1600 #1667

otrho opened this issue May 25, 2022 · 4 comments
Labels
blocked bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen P: critical Should be looked at before anything else

Comments

@otrho
Copy link
Contributor

otrho commented May 25, 2022

There are a couple of notes in the PR #1600 which mustn't be forgotten.

@otrho otrho added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels May 25, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network May 25, 2022
@mohammadfawaz
Copy link
Contributor

Closing in favour of #1682

@otrho are there other issues here that need to be addressed other than the bogus dead code warnings?

Repository owner moved this from Todo to Done in Fuel Network May 26, 2022
@adlerjohn
Copy link
Contributor

@mohammadfawaz yes, this one #1600 (comment)

@adlerjohn adlerjohn mentioned this issue May 26, 2022
2 tasks
@adlerjohn adlerjohn reopened this May 26, 2022
Repository owner moved this from Done to In Progress in Fuel Network May 26, 2022
@adlerjohn adlerjohn changed the title Address the problem with OrdEq and bogus dead code warnings discovered during #1600 Address the problem with OrdEq discovered during #1600 May 26, 2022
@mohammadfawaz
Copy link
Contributor

mohammadfawaz commented May 26, 2022

Ah perfect.

Referring to:

// TODO this doesn't work?

Uncommenting the above leads to the following error:

error
  --> sway-lib-std/src/u128.sw:49:1
   |
47 |   
48 |   // TODO this doesn't work?
49 | / impl core::ops::OrdEq for U128 {
50 | | }
   | |_^ The trait "Ord" is not implemented for type "struct U128<u64, u64>"
51 |   
52 |   fn disable_overflow() {
   |

@mohammadfawaz mohammadfawaz added P: critical Should be looked at before anything else compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen and removed compiler General compiler. Should eventually become more specific as the issue is triaged labels May 26, 2022
@canndrew canndrew self-assigned this Jun 9, 2022
@mohammadfawaz
Copy link
Contributor

mohammadfawaz commented Jun 17, 2022

Have we decided that this is blocked by the declarations engine? Marking as blocked for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen P: critical Should be looked at before anything else
Projects
Status: Blocked
Development

No branches or pull requests

5 participants