Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the dependency on fuel-tx in forc-pkg to fuel-types #2115

Closed
mohammadfawaz opened this issue Jun 25, 2022 · 1 comment · Fixed by #3181
Closed

Move the dependency on fuel-tx in forc-pkg to fuel-types #2115

mohammadfawaz opened this issue Jun 25, 2022 · 1 comment · Fixed by #3181
Labels
code quality dependencies forc

Comments

@mohammadfawaz
Copy link
Contributor

With #2078, forc-pkg now depends on fuel-tx just for the type StorageSlot. It is better to move that dependency to fuel-types instead, so fuel-types must first have StorageSlot as a type.
@mohammadfawaz
Copy link
Contributor Author

Blocked by FuelLabs/fuel-tx#152

@mohammadfawaz mohammadfawaz mentioned this issue Jun 25, 2022
Merged
@adlerjohn adlerjohn moved this to Todo in Fuel Network Jun 25, 2022
@mohammadfawaz mohammadfawaz mentioned this issue Oct 31, 2022
Merged
@Voxelot Voxelot closed this as completed in 11496e6 Nov 2, 2022
Repository owner moved this from Todo to Done in Fuel Network Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality dependencies forc
Projects
Fuel Network
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fuel-core v0.13 upgrade FuelLabs/sway
1 participant
@mohammadfawaz