Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve forc-client abi update logic #6547

Open
kayagokalp opened this issue Sep 15, 2024 · 1 comment
Open

Improve forc-client abi update logic #6547

kayagokalp opened this issue Sep 15, 2024 · 1 comment
Labels
code quality forc-client Everything related to the `forc-client` crate.

Comments

@kayagokalp
Copy link
Member

We should remove the build script if possible, if not we should make sure that it is very robust. One very interesting problem would be related to the comment below:

Since that's a non-greedy capture, it might need to be anchored to the end of the string, otherwise ",\)\); appearing inside the abi source may end the match early:

let re = regex::Regex::new(r#"abigen!\(Contract\(name = "ProxyContract", abi = ".*?",\)\);$"#)

Originally posted by @alfiedotwtf in #6535 (comment)

@kayagokalp
Copy link
Member Author

related to #6527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality forc-client Everything related to the `forc-client` crate.
Projects
None yet
Development

No branches or pull requests

1 participant