Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error handling more consistent throughout forc #851

Closed
mitchmindtree opened this issue Feb 28, 2022 · 0 comments · Fixed by #860
Closed

Make error handling more consistent throughout forc #851

mitchmindtree opened this issue Feb 28, 2022 · 0 comments · Fixed by #860
Assignees
@eureka-cpu
Labels
code quality enhancement New feature or request forc good first issue Good for newcomers

Comments

@mitchmindtree
Copy link
Contributor

Currently there's a combination of anyhow and using Result<T, String>, with the latter being more prevalent.

We should switch to using anyhow everywhere, or consider using thiserror seeing as we currently also expose forc as a library.
@mitchmindtree mitchmindtree added enhancement New feature or request good first issue Good for newcomers forc code quality labels Feb 28, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network Feb 28, 2022
@eureka-cpu eureka-cpu mentioned this issue Mar 2, 2022
Merged
@eureka-cpu eureka-cpu self-assigned this Mar 2, 2022
Repository owner moved this from Todo to Done in Fuel Network Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eureka-cpu eureka-cpu

Labels
code quality enhancement New feature or request forc good first issue Good for newcomers
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds anyhow where result used to be FuelLabs/sway
2 participants
@mitchmindtree @eureka-cpu