Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - _add_symbol_to_cell_input fails if the first row of cell definition doesn't contain at least cell number, material and density (if present) #105

Open
AlbertoBittes opened this issue Oct 24, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@AlbertoBittes
Copy link
Collaborator

Describe the bug
_add_symbol_to_cell_input assumes that the first line of cell definition includes the material and the density(if cell is not void) of the cell:

        if parentheses:
            if new_cell.get_m() == 0:
                first_row[1] = first_row[1] + " ("
            else:
                first_row[2] = first_row[2] + " ("

In fact, the method assumes that first_row is a list with 2 or 3 elements depending on void/material cell.
In principle one could define only the cell number in the first row and go newline to define everything else. This is very unlikely however.

@AlbertoBittes AlbertoBittes added the bug Something isn't working label Oct 24, 2024
@dodu94
Copy link
Member

dodu94 commented Oct 24, 2024

good catch, do you plan to solve it in the PR you are preparing?

@AlbertoBittes
Copy link
Collaborator Author

I don't think I will have time for that, in the meanwhile I fixed that for our JT60 input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants