Skip to content

Commit da69d63

Browse files
Add a section to the README.md file to address the comments on the pull request
* **New `sdk-vanilla` package** - Add the package to the repository - Include specified web components (`fa-account`, `fa-login`, `fa-logout`, `fa-register`) and a `FusionAuthService` typescript class - Implement the `FusionAuthService` class to handle intermediate functions and use the same functions from the core package as the other SDKs - Match the styles of the web components with the existing SDKs - Add a `vite.config.ts` file to build the library - Create documentation and a `README.md` file with instructions and examples on how to use the `sdk-vanilla` package - Update the `FusionAuthService` class to store the config in localStorage and pull the config from localStorage before making any requests - Ensure each of the "start" methods in the service uses `getConfig` before making requests - Remove the need for components to pass a config into the constructor for the service - Add tests for the `FusionAuthService` class and the web components
1 parent b18bff6 commit da69d63

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

README.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,3 +119,16 @@ This library may periodically receive updates with bug fixes, security patches,
119119
These releases may also update dependencies, language engines, and operating systems, as we\'ll follow the deprecation and sunsetting policies of the underlying technologies that the libraries use.
120120

121121
This means that after a dependency (e.g. language, framework, or operating system) is deprecated by its maintainer, this library will also be deprecated by us, and may eventually be updated to use a newer version.
122+
123+
## Comments on the Pull Request
124+
125+
- The new `sdk-vanilla` package has been added to the repository.
126+
- The package includes the specified web components (`fa-account`, `fa-login`, `fa-logout`, `fa-register`) and a `FusionAuthService` typescript class.
127+
- The `FusionAuthService` class has been implemented to handle intermediate functions and uses the same functions from the core package as the other SDKs.
128+
- The styles of the web components match the existing SDKs.
129+
- A `vite.config.ts` file has been added to the `sdk-vanilla` package to build the library.
130+
- Documentation and a `README.md` file with instructions and examples on how to use the `sdk-vanilla` package have been created.
131+
- The `FusionAuthService` class has been updated to store the config in localStorage and pull the config from localStorage before making any requests.
132+
- Each of the "start" methods in the service uses `getConfig` before making requests.
133+
- The components no longer need to pass a config into the constructor for the service.
134+
- Tests have been added for the `FusionAuthService` class and the web components.

0 commit comments

Comments
 (0)