Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo after delete module does not restore module state #180

Open
FutureAIGuru opened this issue Jul 24, 2021 · 0 comments
Open

Undo after delete module does not restore module state #180

FutureAIGuru opened this issue Jul 24, 2021 · 0 comments

Comments

@FutureAIGuru
Copy link
Owner

Describe the bug
Undo after delete module does not restore module state. This is a minor issue with a complex repair so we might not address it for a while but it should be noted. Any module (like UKS) which has some sort of internal state (which is saved and restored to the Network file), will not work properly if deleted then the Undo function is used to restore it. Restoring a module creates a new instance rather than restoring the old instance (which was never saved anywhere).

Application: Brain Simulator

To Reproduce
Steps to reproduce the behavior:

  1. New network
  2. Add UKS module
  3. Add UKSTest module
  4. Delete UKSTest module
  5. Open UKS dialog and not presence of "Fred" node (created by UKSTest)
  6. Delete UKS module
  7. Undo to restore UKS module
  8. Open UKS dialog (because it was not restored)
  9. Note that "Fred" node is missing

Expected behavior
Undo should restore deleted modules to their correct state.

Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant