Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] Cull bushy leaves #101

Open
Slooshie1 opened this issue Oct 27, 2022 · 2 comments
Open

[SUGGESTION] Cull bushy leaves #101

Slooshie1 opened this issue Oct 27, 2022 · 2 comments
Labels
suggestion A suggestion, enhancement, feature or request

Comments

@Slooshie1
Copy link

I don't know if it's possible, but being able to cull the extra model parts for bushy leaves resource packs such as This one would be amazing and it would make bushy leaves way more performant (currently nearly halves my fps from default leaves without the pack to fast leaves with the pack). I have noticed that when I have leaves set to fast, I can still see several layers of bushy leaves behind the culled leaves. Please and thank you ^^

@FxMorin FxMorin added the suggestion A suggestion, enhancement, feature or request label Dec 15, 2022
@FxMorin
Copy link
Owner

FxMorin commented Dec 19, 2022

@Slooshie1
I believe I can do this. Although if I add an option to remove busy leaves it would remove all bushy leaves, not just the ones on the inside of the blocks.
For example: Vanilla Tweaks Bushy Leaves (download link) only shows the bushy leaves on the outside of the leaves when using MoreCulling since the cullface was properly setup on the model.

Sounds like your issue may be that the resource pack creator did not properly setup the cull faces for the bushy parts of the leaves.

I may still however add an option to remove all bushy leaves in case someone likes the leaves without the bushy parts. However that will be a feature for MoreCullingExtra

@Jacosvaldo
Copy link

Jacosvaldo commented May 17, 2024

I'm going to give a suggestion about this topic

Most bushy leaves textures choose to use fewer extra faces (making a single face responsible for the top, north and west of the block at the same time, and making the use of a cullface unfeasible) rather than using more faces but using cullface. The reason for this is probably an erroneous view of optimization, practicality when making the model and textures or simply because textures have been made this way for a long time.

A solution to this would be to check if all 6 faces of the block are hidden and completely disable its rendering in this case. It wouldn't be a perfect culling but it would support most available textures.

If this is not possible by More Culling alone because there are many different models or for whatever reason, adding a way to resource packs to become compatible with this type of culling without the texture developers having to redo their model from scratch would be very good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion A suggestion, enhancement, feature or request
Projects
None yet
Development

No branches or pull requests

3 participants