Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some items in item frames have visible faces culled #163

Closed
muzikbike opened this issue May 14, 2023 · 3 comments
Closed

Some items in item frames have visible faces culled #163

muzikbike opened this issue May 14, 2023 · 3 comments

Comments

@muzikbike
Copy link

I'm not sure if it'd be possible to have some sort of check implemented to make sure the face to be culled is a certain distance far into the block (perhaps configurable via resource packs to accommodate custom item frame models?) before it actually ends up being culled.

This effect can be seen with azaleas, sculk shriekers, composters and scaffolding. I've also been able to see it in cauldrons if we make them use the cauldron block model in item form.
2023-05-14_16 49 45
2023-05-14_16 49 56
2023-05-14_16 50 04
2023-05-14_16 50 08

@prototype464
Copy link

This is one of those bugs you see and it's so small it wouldn't be noticed by nearly anyone using this mod, and you wonder how the hell the issue author caught it in the first place, or if it'll actually be fixed because it's a small thing

Anyway, nice catch!

@FxMorin
Copy link
Owner

FxMorin commented Jun 20, 2023

muzikbike is a culling expert.
This is something I might fix at some point, however im too busy to do that these days

@FxMorin FxMorin closed this as completed in c973340 Jan 8, 2024
@FxMorin
Copy link
Owner

FxMorin commented Jan 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants