Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "Random" leaves culling to be affected by the "Depth" slider #267

Open
kesakat opened this issue Jul 18, 2024 · 2 comments
Open

Allow "Random" leaves culling to be affected by the "Depth" slider #267

kesakat opened this issue Jul 18, 2024 · 2 comments
Labels
suggestion A suggestion, enhancement, feature or request TODO This is good and just needs to be implemented

Comments

@kesakat
Copy link

kesakat commented Jul 18, 2024

Cull Less Leaves does something similar to this, allowing the user to define a percentage of faces to be rejected alongside its depth culling approach, this is an option that was both beneficial to performance and also allowed trees to still look good without the disaster that is non-depth random and without the blocky feeling that comes from pure depth (it also makes the shadows that leaves give off look way better when using shaders). i would also prefer an option to control how much leaves are culled by random but that is not as necessary.

normally i would not write an issue for this, but as is known, cull less leaves now marks itself as incompatible with more culling, so i cannot use that mods superior system alongside this mods overall performance. since i doubt the possibility of getting them to just remove the incompatibility i ask here to just port the system over

@kesakat
Copy link
Author

kesakat commented Jul 18, 2024

Noticing now, apologies if this might already exist in the mod, i use mc version 1.19.2 and i notice now that this mod does not seem to backport its newer versions to older mc versions. though i still ask, even if this change will not affect me, that this may be done should it not yet be a thing already

@FxMorin
Copy link
Owner

FxMorin commented Jul 28, 2024

This is a cool idea. If I get the time, I may implement this.

@FxMorin FxMorin added suggestion A suggestion, enhancement, feature or request TODO This is good and just needs to be implemented labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion A suggestion, enhancement, feature or request TODO This is good and just needs to be implemented
Projects
None yet
Development

No branches or pull requests

2 participants